3 more fixes to UnsafeRow serialization #4797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D45446862 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
May 1, 2023
Summary: Pull Request resolved: facebookincubator#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Differential Revision: D45446862 fbshipit-source-id: ab217bfa38380dedd9c1e90dd9519371d93a0e3b
|
This pull request was exported from Phabricator. Differential Revision: D45446862 |
mbasmanova
reviewed
May 1, 2023
There was a problem hiding this comment.
@pedroerp Pedro, thank you for the fixes. Would you also update documentation to explain these details?
mbasmanova
reviewed
May 1, 2023
| testDeserialize(data, 20, expected); | ||
| } | ||
|
|
||
| TEST_F(UnsafeRowSerializerTest, string) { |
There was a problem hiding this comment.
Should these tests go into velox/row/tests/UnsafeRowSerdeTest.cpp ?
There was a problem hiding this comment.
These test the full "package" or "stream" (the size, plus potentially many unsafe rows). The ones under velox/row only test the content of a single unsafe row.
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
May 1, 2023
Summary: Pull Request resolved: facebookincubator#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Differential Revision: D45446862 fbshipit-source-id: 5ed254ce7663cd811a796ac3808333cc554ce903
|
This pull request was exported from Phabricator. Differential Revision: D45446862 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
May 1, 2023
Summary: Pull Request resolved: facebookincubator#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 4480ff99f7b784459d2f7f778d8f8d9371cda0a1
|
This pull request was exported from Phabricator. Differential Revision: D45446862 |
Summary: Pull Request resolved: facebookincubator#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0e43d4e8f7254234870bf09567fd2ecd7e158e88
|
This pull request was exported from Phabricator. Differential Revision: D45446862 |
pedroerp
added a commit
to pedroerp/presto
that referenced
this pull request
May 2, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
|
This pull request has been merged in 7d5cf2f. |
xiaoxmeng
pushed a commit
to prestodb/presto
that referenced
this pull request
May 3, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
wanglinsong
pushed a commit
to prestodb/presto
that referenced
this pull request
May 10, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
wanglinsong
pushed a commit
to prestodb/presto
that referenced
this pull request
May 17, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
Mionsz
pushed a commit
to Mionsz/presto
that referenced
this pull request
Jun 2, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
yiweiHeOSS
pushed a commit
to yiweiHeOSS/velox
that referenced
this pull request
Jul 15, 2023
Summary: X-link: prestodb/presto#19502 Pull Request resolved: facebookincubator#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. diff-train-skip-merge Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 74366c7e76ab1467c5e68d321430ad9da5b3830a
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Dec 22, 2023
Summary: X-link: facebookincubator/velox#4797 3 more fixes to UnsafeRow serialization to make it compatible with Spark Java: - The first integer that describes the row size needs to be 32 not 64 bits. - This integer needs to be serialized in big endian order. Curiously, the remaining integers within the UnsafeRow itself are little endian. - The input buffer allocated needs to be initialized to zero, since not all portions of it will be initialized in the UnsafeRow serialization code. Reviewed By: mbasmanova Differential Revision: D45446862 fbshipit-source-id: 0961b9a27f367803bb1da149729128c0a6dbc15f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
3 more fixes to UnsafeRow serialization to make it compatible with
Spark Java:
remaining integers within the UnsafeRow itself are little endian.
portions of it will be initialized in the UnsafeRow serialization code.
Differential Revision: D45446862