Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inverse_binomial_cdf Presto function #5270

Closed
wants to merge 0 commits into from
Closed

Add Inverse_binomial_cdf Presto function #5270

wants to merge 0 commits into from

Conversation

rrando901
Copy link
Contributor

@rrando901 rrando901 commented Jun 14, 2023 •
edited by majetideepak
Loading

Add Presto function Inverse_binomial_cdf following the Java implementation(source)

Resolves: #5251

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2023
@netlify
Copy link

netlify bot commented Jun 14, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 787b688
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/64962be1f0a2ae0007aec47e

aditi-pandit
aditi-pandit reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this function. It looks good overall.

velox/functions/prestosql/tests/ProbabilityTest.cpp Outdated Show resolved Hide resolved
velox/functions/prestosql/tests/ProbabilityTest.cpp Outdated Show resolved Hide resolved
velox/functions/prestosql/tests/ProbabilityTest.cpp Outdated Show resolved Hide resolved
@rrando901 rrando901 requested a review from aditi-pandit June 15, 2023 22:29
@rrando901
Copy link
Contributor Author

@aditi-pandit @majetideepak I've addressed all initial review comments.
Please re-review when you get a chance. Thanks.

@aditi-pandit
Copy link
Collaborator

aditi-pandit commented Jun 21, 2023 •
edited
Loading

@aditi-pandit @majetideepak I've addressed all initial review comments. Please re-review when you get a chance. Thanks.

Thanks @rrando901.

The linux-build also has a test timeout failure (not related to this PR though). Please can you rebase your code and force push this again so that it re-triggers tests.

@rrando901 rrando901 requested a review from aditi-pandit June 21, 2023 17:03
aditi-pandit
aditi-pandit approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@aditi-pandit aditi-pandit requested review from Yuhta and mbasmanova June 21, 2023 17:24
@aditi-pandit
Copy link
Collaborator

@rrando901 : The linux-tests show a fuzzer failure with this function. Please can you look into it. More information on the fuzzer at https://facebookincubator.github.io/velox/develop/testing/fuzzer.html

@ashokku2022 ashokku2022 mentioned this pull request Jun 22, 2023
Open
@rrando901 rrando901 closed this Jun 23, 2023
@rrando901 rrando901 force-pushed the main branch 2 times, most recently from 9613e57 to 787b688 Compare June 23, 2023 23:33
@rrando901
Copy link
Contributor Author

@aditi-pandit @ashokku2022 @majetideepak
Changes moved to #5382. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-pandit aditi-pandit aditi-pandit approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak

@Yuhta Yuhta Awaiting requested review from Yuhta

@mbasmanova mbasmanova Awaiting requested review from mbasmanova

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement inverse_binomial_cdf prestosql function
4 participants
@rrando901 @aditi-pandit @majetideepak @facebook-github-bot