Use shrink pools by arbitrator for spill test in hash join uni test #8932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
force-pushed
the
prepare4
branch
2 times, most recently
from
405f095 to
0876cbd
Compare
xiaoxmeng
requested review from
mbasmanova,
tanjialiang,
duanmeng and
bikramSingh91
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
reviewed
Mar 1, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
approved these changes
Mar 2, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Mar 2, 2024
…acebookincubator#8932) Summary: - Add flag in OperatorTestBase to configure shared arbitrator to use in unit test - Switch to use new api to create query pool and add the memory reclaimer to work with shared arbitrator - Hash build switch to use test utility to trigger spilling by calling shared arbitrator's shrink pools function - Improve the shrink pool test utility to ensure the memory pool is always associated with its memory manager - Turn on shared arbitrator in hash join unit test Eventually, we will make shared arbitrator the default for unit testing. Reviewed By: tanjialiang Differential Revision: D54432889 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D54432889 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Mar 2, 2024
…acebookincubator#8932) Summary: - Add flag in OperatorTestBase to configure shared arbitrator to use in unit test - Switch to use new api to create query pool and add the memory reclaimer to work with shared arbitrator - Hash build switch to use test utility to trigger spilling by calling shared arbitrator's shrink pools function - Improve the shrink pool test utility to ensure the memory pool is always associated with its memory manager - Turn on shared arbitrator in hash join unit test Eventually, we will make shared arbitrator the default for unit testing. Reviewed By: tanjialiang Differential Revision: D54432889 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D54432889 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Mar 2, 2024
…acebookincubator#8932) Summary: - Add flag in OperatorTestBase to configure shared arbitrator to use in unit test - Switch to use new api to create query pool and add the memory reclaimer to work with shared arbitrator - Hash build switch to use test utility to trigger spilling by calling shared arbitrator's shrink pools function - Improve the shrink pool test utility to ensure the memory pool is always associated with its memory manager - Turn on shared arbitrator in hash join unit test Eventually, we will make shared arbitrator the default for unit testing. Reviewed By: tanjialiang Differential Revision: D54432889 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D54432889 |
…acebookincubator#8932) Summary: - Add flag in OperatorTestBase to configure shared arbitrator to use in unit test - Switch to use new api to create query pool and add the memory reclaimer to work with shared arbitrator - Hash build switch to use test utility to trigger spilling by calling shared arbitrator's shrink pools function - Improve the shrink pool test utility to ensure the memory pool is always associated with its memory manager - Turn on shared arbitrator in hash join unit test Eventually, we will make shared arbitrator the default for unit testing. Reviewed By: tanjialiang Differential Revision: D54432889 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D54432889 |
|
@xiaoxmeng merged this pull request in f391c02. |
PHILO-HE
added a commit
to PHILO-HE/velox
that referenced
this pull request
Mar 4, 2024
…i test (facebookincubator#8932)" This reverts commit f391c02.
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…acebookincubator#8932) Summary: - Add flag in OperatorTestBase to configure shared arbitrator to use in unit test - Switch to use new api to create query pool and add the memory reclaimer to work with shared arbitrator - Hash build switch to use test utility to trigger spilling by calling shared arbitrator's shrink pools function - Improve the shrink pool test utility to ensure the memory pool is always associated with its memory manager - Turn on shared arbitrator in hash join unit test Eventually, we will make shared arbitrator the default for unit testing. Pull Request resolved: facebookincubator#8932 Reviewed By: tanjialiang Differential Revision: D54432889 Pulled By: xiaoxmeng fbshipit-source-id: 484ccf356a555be837bfa4fa64fb03e6d16c8cb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work with shared arbitrator
shrink pools function
with its memory manager
Eventually, we will make shared arbitrator the default for unit testing.