Enable customization of party performing public computations #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
The current implementation of CrypTen's MPC protocol assumes that there is always a party with rank 0. This party is hardcoded to be responsible for performing public addition, public XOR, NOT, and for requesting Beaver triples. In setups in which party 0 exists but does not partake in the computations (that is, is not in
DistributedCommunicator.main_group
) incorrect results will be produced..This PR introduces class variables that allow a user to customize which party is in charge of those things.
How Has This Been Tested (if it applies)
Unit tests for public addition, public XOR, and NOT included. There are no unit tests for TTP and TFP, but I have tested the changes locally.
Checklist