Creating required files for pypi release #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
pringshia
approved these changes
Sep 20, 2021
pringshia
pushed a commit
that referenced
this pull request
Sep 23, 2021
pringshia
added a commit
that referenced
this pull request
Sep 23, 2021
* Layout base folder structure * rename scripts pkg to dev-scripts * Add base README * Get dev-scripts working * Wire up new transition storybook under docs/sb * Fix up .yarnrc.yml * Set up @annotated/bbox package * Add @annotated/video-player pkg * Add more stories to the storybook * Typo fix (#564) * Cleaning up todo labels (#569) * Creating required files for pypi release (#548) * Create annotated-pks.yml * Remove yarn version specificiation from install * Remove random echo statements * Update build command * Update wrapper import * Remove cra scripts from package.json * Add foreach build command * change job name Co-authored-by: Jack Urbanek <jju@fb.com>
pringshia
added a commit
that referenced
this pull request
Sep 24, 2021
* Layout base folder structure * rename scripts pkg to dev-scripts * Add base README * Get dev-scripts working * Wire up new transition storybook under docs/sb * Fix up .yarnrc.yml * Set up @annotated/bbox package * Add @annotated/video-player pkg * Add more stories to the storybook * Add a Github Action for testing Yarn 3 (#574) * Layout base folder structure * rename scripts pkg to dev-scripts * Add base README * Get dev-scripts working * Wire up new transition storybook under docs/sb * Fix up .yarnrc.yml * Set up @annotated/bbox package * Add @annotated/video-player pkg * Add more stories to the storybook * Typo fix (#564) * Cleaning up todo labels (#569) * Creating required files for pypi release (#548) * Create annotated-pks.yml * Remove yarn version specificiation from install * Remove random echo statements * Update build command * Update wrapper import * Remove cra scripts from package.json * Add foreach build command * change job name Co-authored-by: Jack Urbanek <jju@fb.com> * Create @annotated/keypoint * Add build-all pkg.json script * Add README for yarn * Move sb into storybook folder and update README * Remove manifest and logos * Clean up Co-authored-by: Jack Urbanek <jju@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In order to get PyPI releases working, this sets up the minimum packaging setup that also includes all of the static files we require to run Mephisto. Once this is merged I'll release
0.4.1, which should be our first full PyPI release.Concerns & Future work
Right now I've set this up to be able to upload via the classic
setup.pyroute, rather than usingpoetryas we have tried to for other parts of the project. I think this signals a degradation of the developer experience, however I couldn't see a quick resolution that allows us to usepip install -e .for local development using just poetry before. Digging in, it appears to be blocked by pip here: pypa/pip#6950, and should be resolved by PEP 660 which is targeted for pip 21.3 (October). We should revisit consolidating around poetry then.Closes #524