-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 18 #905
Update to React 18 #905
Conversation
Codecov ReportBase: 64.06% // Head: 64.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 64.06% 64.13% +0.07%
==========================================
Files 108 108
Lines 9445 9445
==========================================
+ Hits 6051 6058 +7
+ Misses 3394 3387 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to be able to unblock! And also looking forward to the future annotated repo 👀
Several package.json files named parlai-mturk-task-compiler include an old version of the react-table lib @ version 6, which has react 16 max as the peer dep.
The only usage in Mephisto and the ParlAI libraries is in this file.
I'm inclined to deprecate that folder for now and in doing so also sunset the old |
* Copy over PR#899 * Add `FORCE_COLOR: 0` to fix setup-node@v3 + GitHub Actions incompatibility modernweb-dev/web#1839 * Upgrade yarn version * fiddle with FORCE_COLOR * Fiddle with FORCE_COLOR * Try different solution for yarn cache GHA error * Try different solution for yarn cache GHA error * Relax peer deps and remove FORCE_COLOR * Updated lock file * Deprecate @Annotated for now * Downgrade react-bootstrap to match last prior working version * fix syntax error * Remove storybook check workflow * Update peer deps for mephisto-task, relaxing them * Update lockfile * Fix lint * Bump mephisto-task to v2.0.4 * Upgrade all projects to latest mephisto version * Add updated lockfile * Try out differnet workflow file command * Try with updated lockfile instead * Update peer deps and react versions across the codebase * Add updated lockfile * Try reordering the test * remove all package-lock.json files and run prettier * Downgrade react to 16 because of old version of react-table * Fix peer deps for mephisto-worker-addons * Downgrade more react versions to 16 because of react-table, which were missed earlier * Add udpated lockfile * Upate published peer deps for mephisto-worker-addons * Update prettierignore * try Cypress fix * Add cypress * Add Cypress * Add prebuild step to cypress actions * Fix cypress installation format * Version bump bootstrap-chat * Update lcokfile
Fixes #964, fixes #991
Got all tests passing! 🥳
Resuming work from #899 as a base and trying to get tests to pass.
Took almost all of an entire day but I think I got it. Key updates:
./sync_package_version.sh mephisto-task 2.0.4
Other notes:
react-bootstrap
since the components we use are missing in the newer version: https://stackoverflow.com/a/60101003parlai-mturk-task-compiler
include an old version of thereact-table
lib @ version 6, which has react 16 max as the peer dep. Upgrading isn't straightforward I think since the library has undergone major changes in v7 (and is now at v8)