Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 18 #905

Merged
merged 38 commits into from
Jan 27, 2023
Merged

Update to React 18 #905

merged 38 commits into from
Jan 27, 2023

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Oct 3, 2022

Fixes #964, fixes #991

Got all tests passing! 🥳

Resuming work from #899 as a base and trying to get tests to pass.

Took almost all of an entire day but I think I got it. Key updates:

  • Published mephisto-task@2.0.4 which includes relaxed react peer deps
  • Published mephisto-worker-addons@1.0.2 which includes relaxed react peer deps
  • Published bootstrap-chat@2.0.2 which includes relaxed react peer deps
  • Ran ./sync_package_version.sh mephisto-task 2.0.4
  • Disabled storybook and @annotated/* packages from the workspace for now, they're overcomplicating the build and I think it makes sense to move those types of UI components into their own repo anyway
  • Fixed failing Cypress tests. After much hunting it seems that Cypress builds are failing due to v12 changes. Migration guide isn't clear as to why though. This PR pins CI version to v11.

Other notes:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2022
@pringshia pringshia closed this Oct 3, 2022
@pringshia pringshia reopened this Oct 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 64.06% // Head: 64.13% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (fbf99f0) compared to base (9e44e8c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   64.06%   64.13%   +0.07%     
==========================================
  Files         108      108              
  Lines        9445     9445              
==========================================
+ Hits         6051     6058       +7     
+ Misses       3394     3387       -7     
Impacted Files Coverage Δ
...sto/abstractions/architects/router/build_router.py 86.79% <100.00%> (ø)
...tractions/architects/channels/websocket_channel.py 78.90% <0.00%> (+2.34%) ⬆️
mephisto/abstractions/architects/mock_architect.py 90.84% <0.00%> (+2.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pringshia pringshia requested a review from JackUrb January 27, 2023 04:36
@pringshia pringshia linked an issue Jan 27, 2023 that may be closed by this pull request
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to be able to unblock! And also looking forward to the future annotated repo 👀

Several package.json files named parlai-mturk-task-compiler include an old version of the react-table lib @ version 6, which has react 16 max as the peer dep.

The only usage in Mephisto and the ParlAI libraries is in this file.

@pringshia
Copy link
Contributor Author

pringshia commented Jan 27, 2023

I'm inclined to deprecate that folder for now and in doing so also sunset the old react-table dependency. That client UI was exploratory and hasn't been used for any meaningful projects since.

@pringshia pringshia merged commit aa12f91 into main Jan 27, 2023
@pringshia pringshia deleted the react-deps branch January 27, 2023 20:06
jayhuynh pushed a commit to d-lab/mephisto that referenced this pull request Mar 17, 2023
* Copy over PR#899

* Add `FORCE_COLOR: 0` to fix setup-node@v3 + GitHub Actions incompatibility

modernweb-dev/web#1839

* Upgrade yarn version

* fiddle with FORCE_COLOR

* Fiddle with FORCE_COLOR

* Try different solution for yarn cache GHA error

* Try different solution for yarn cache GHA error

* Relax peer deps and remove FORCE_COLOR

* Updated lock file

* Deprecate @Annotated for now

* Downgrade react-bootstrap to match last prior working version

* fix syntax error

* Remove storybook check workflow

* Update peer deps for mephisto-task, relaxing them

* Update lockfile

* Fix lint

* Bump mephisto-task to v2.0.4

* Upgrade all projects to latest mephisto version

* Add updated lockfile

* Try out differnet workflow file command

* Try with updated lockfile instead

* Update peer deps and react versions across the codebase

* Add updated lockfile

* Try reordering the test

* remove all package-lock.json files and run prettier

* Downgrade react to 16 because of old version of react-table

* Fix peer deps for mephisto-worker-addons

* Downgrade more react versions to 16 because of react-table, which were missed earlier

* Add udpated lockfile

* Upate published peer deps for mephisto-worker-addons

* Update prettierignore

* try Cypress fix

* Add cypress

* Add Cypress

* Add prebuild step to cypress actions

* Fix cypress installation format

* Version bump bootstrap-chat

* Update lcokfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update react version in mephisto-task Cypress Testing is Broken
4 participants