Skip to content

Commit

Permalink
Fix: Implement fixes for remote evaluation (#109)
Browse files Browse the repository at this point in the history
* implement fixes for remote evaluation

* another spelling fix

* fixing a weird nltk not found error

* attempt to download missing nltk files in main.yml

* attempt to download nltk

* attempt to download nltk with python -c

* change the python command according to the error message
  • Loading branch information
Epic-Eric authored Aug 14, 2024
1 parent 7b45f68 commit 439c937
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/tutorials/remote_evaluation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ For instance, with the agent in :ref:`first-agent`,

.. code-block:: bash
> simuleval --standalone --remote-port 8888 --agent first_agent.py.py
> simuleval --standalone --remote-port 8888 --agent first_agent.py
2022-12-06 19:12:26 | INFO | simuleval.cli | Evaluate system: DummyWaitkTextAgent
2022-12-06 19:12:26 | INFO | simuleval.agent_server | Simultaneous Translation Server Started (process id 53902). Listening to port 8888
Expand Down
8 changes: 4 additions & 4 deletions examples/quick_start/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM python:3.8
RUN apt-get update \
&& apt-get upgrade -y \
&& apt-get install -y \
&& apt-get -y install apt-utils gcc libpq-dev libsndfile-dev
&& apt-get upgrade -y \
&& apt-get install -y \
&& apt-get -y install apt-utils gcc libpq-dev libsndfile-dev
RUN git clone https://github.com/facebookresearch/SimulEval.git
WORKDIR SimulEval
RUN git checkout v1.1.0
RUN pip install -e .
CMD ["simuleval", "--standalone", "--remote-port", "8888", "--agent", "examples/quick_start/first_agent.py.py"]
CMD ["simuleval", "--standalone", "--remote-port", "8888", "--agent", "examples/quick_start/first_agent.py"]
2 changes: 1 addition & 1 deletion simuleval/evaluator/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def results(self):
return self.evaluator.results()

def remote_eval(self):
for instance in self.evaluator.instance_iterator:
for instance in self.evaluator.iterator:
self.system_reset()
while not instance.finish_prediction:
self.send_source(instance.send_source(self.source_segment_size))
Expand Down

0 comments on commit 439c937

Please sign in to comment.