Fix: typos and logic errors #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed visualize.py via argparse. Now user may add --visualize in the terminal to have the graph output to the output folder
… .png file. Add ability to read multiple dictionaries from instances.log
…r with and without _CA
facebook-github-bot
added
the
CLA Signed
|
Hi @Epic-Eric, thanks for the PR. Could you separate the change for the issue from the #107? |
Epic-Eric
commented
Aug 4, 2024
| with open( | ||
| self.output / "instances.log", "a" | ||
| ) if self.output else contextlib.nullcontext() as file: | ||
| with ( |
There was a problem hiding this comment.
Black formatting change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue #44.
Problem 1: Speech type displayed even though text is given for target.
Solution 1: Typo fix.
Problem 2: The latency metrics are the same between each pair, like LAAL is the same is LAAL_CA, where LAAL_CA should be bigger due to considering elapsed time which counts computer processing time along with delays.
Solution 2: The problem was that when “--computation-aware” argument was passed in args, it was set globally to True, causing all the metric object to take on ‘computation_aware’=True. The fix was very simple, just one line of code. In from_args which instantiates the object, I put ‘computation_aware’ to False. If it’s _CA, then it goes through a different pathway and instantiates the object directly not through from_args.
(Metrics shown are now correct)
Type of change
How Has This Been Tested?
Successful locally. No test cases needed.