-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Docker environment for remote speech to text evaluation #110
Conversation
…docker Update to local remote changes
.github/workflows/main.yml
Outdated
@@ -34,6 +34,7 @@ jobs: | |||
pip install sentencepiece | |||
pip install -e . | |||
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | |||
python -c "import nltk; nltk.download('averaged_perceptron_tagger_eng')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why is nltk added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not adding nltk made test_tree_pipeline_cmd in test_agent_pipeline.py to fail. It only happened recently, and wasn't an issue when I submitted the visualization PR. I have no clue why, but the error message told me that I need to nltk.download so I did
Description
Docker creates a container where the operating system and dependencies are uniform and the setup process is streamlined.
To build the docker file, first change the directory to
speech_to_text
in the terminal from Simuleval parent folder:Then, build the Docker image with:
Next, run the remote evaluation server using the Docker image:
This binds port 8888 of the container (server) to port 8888 on the local machine (client).
To pass data to the server and execute remote evaluation, open another terminal, and change its directory to
examples/speech_to_text
. Finally, you can access the server with the following code for instance:Example input
Example output
Type of change
How Has This Been Tested?
Tested locally first, as there were some bugs with the upstream repository as detailed here:
#109
Using
COPY . /Simuleval
instead ofRUN git clone https://github.com/facebookresearch/SimulEval
in the Dockerfile, I tested my local changes and ensured they worked as expected.