Optimizer state scaling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 94.18% 94.28% +0.09%
==========================================
Files 35 35
Lines 2065 2100 +35
==========================================
+ Hits 1945 1980 +35
Misses 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andersonic
force-pushed
the
optimizer-state-scaling
branch
2 times, most recently
from
744713f to
0eb5ad3
Compare
andersonic
requested review from
shruti-bh,
msbaines,
sidgoyal78 and
blefaudeux
added 12 commits
August 21, 2020 10:26
andersonic
force-pushed
the
optimizer-state-scaling
branch
from
8295557 to
fce8747
Compare
sidgoyal78
reviewed
Aug 21, 2020
added 3 commits
August 21, 2020 13:39
This reverts commit 7f66480.
sidgoyal78
approved these changes
Aug 22, 2020
shruti-bh
approved these changes
Aug 22, 2020
| @@ -236,10 +236,10 @@ def benchmark_language_model(train_data, val_data, test_data, model, criterion, | |||
|
|
|||
| # Assert that memory usage on each GPU is within 10% of golden run | |||
| # Right-hand-side is golden run bytes * 110% | |||
| assert torch.cuda.memory_stats(0)["allocated_bytes.all.peak"] < 210479616 * 1.1 | |||
| assert torch.cuda.memory_stats(0)["allocated_bytes.all.peak"] < 193206272 * 1.1 | |||
There was a problem hiding this comment.
how did you come up with these number of bytes?
There was a problem hiding this comment.
I had the same question in one of the previous PRs :D
I guess Jun-Ru printed out the value of torch.cuda.memory_stats(0)["allocated_bytes.all.peak"] and put that number in the check!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Allows scaling of optimizer state.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃