Switch to Python logging (+ lint) (#646) #1627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Python logging offers a number of benefits, such as logging timestamps, better cross-library compatibility, ability to add multiple output handlers, etc. Pull Request resolved: fairinternal/fairseq-py#646 Reviewed By: spencerp Differential Revision: D15815620 Pulled By: myleott fbshipit-source-id: 801c615ed523c1560b2dc770942787787839b158
|
This pull request was exported from Phabricator. Differential Revision: D15815620 |
moussaKam
pushed a commit
to moussaKam/language-adaptive-pretraining
that referenced
this pull request
Sep 29, 2020
Summary: Pull Request resolved: facebookresearch#1627 Python logging offers a number of benefits, such as logging timestamps, better cross-library compatibility, ability to add multiple output handlers, etc. Pull Request resolved: fairinternal/fairseq-py#646 Reviewed By: spencerp Differential Revision: D15815620 Pulled By: myleott fbshipit-source-id: 5e64e9929b5e4b9dd5bb49bcdf7c510631907134
yzpang
pushed a commit
to yzpang/gold-off-policy-text-gen-iclr21
that referenced
this pull request
Feb 19, 2021
Summary: Pull Request resolved: facebookresearch/fairseq#1627 Python logging offers a number of benefits, such as logging timestamps, better cross-library compatibility, ability to add multiple output handlers, etc. Pull Request resolved: fairinternal/fairseq-py#646 Reviewed By: spencerp Differential Revision: D15815620 Pulled By: myleott fbshipit-source-id: 5e64e9929b5e4b9dd5bb49bcdf7c510631907134
yzpang
pushed a commit
to yzpang/gold-off-policy-text-gen-iclr21
that referenced
this pull request
Feb 19, 2021
Summary: Pull Request resolved: facebookresearch/fairseq#1627 Python logging offers a number of benefits, such as logging timestamps, better cross-library compatibility, ability to add multiple output handlers, etc. Pull Request resolved: fairinternal/fairseq-py#646 Reviewed By: spencerp Differential Revision: D15815620 Pulled By: myleott fbshipit-source-id: 5e64e9929b5e4b9dd5bb49bcdf7c510631907134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Python logging offers a number of benefits, such as logging timestamps, better
cross-library compatibility, ability to add multiple output handlers, etc.
Pull Request resolved: https://github.com/fairinternal/fairseq-py/pull/646
Reviewed By: spencerp
Differential Revision: D15815620
Pulled By: myleott