Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make AVX2-detection platform-independent #1600

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions faiss/python/loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,30 +3,39 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

from distutils.version import LooseVersion
import platform
import subprocess
import logging


def instruction_set():
def supports_AVX2():
import numpy
if LooseVersion(numpy.__version__) >= "1.19":
# use private API as next-best thing until numpy/numpy#18058 is solved
from numpy.core._multiarray_umath import __cpu_features__
return __cpu_features__["AVX2"]

# platform-dependent fallback before numpy 1.19, no windows
if platform.system() == "Darwin":
if subprocess.check_output(["/usr/sbin/sysctl", "hw.optional.avx2_0"])[-1] == '1':
return "AVX2"
return True
else:
return "default"
return False
elif platform.system() == "Linux":
import numpy.distutils.cpuinfo
if "avx2" in numpy.distutils.cpuinfo.cpu.info[0].get('flags', ""):
return "AVX2"
return True
else:
return "default"
return False
return False


logger = logging.getLogger(__name__)

try:
instr_set = instruction_set()
if instr_set == "AVX2":
has_AVX2 = supports_AVX2()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the instruction_set name here generic since Faiss also compiles on ARM and PPC.

if has_AVX2:
logger.info("Loading faiss with AVX2 support.")
from .swigfaiss_avx2 import *
else:
Expand Down