Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve distances_simd.cpp for aarch64 #2392

Closed
wants to merge 2 commits into from
Closed

Improve distances_simd.cpp for aarch64 #2392

wants to merge 2 commits into from

Conversation

wx257osn2
Copy link
Contributor

@wx257osn2 wx257osn2 commented Jul 20, 2022 •
edited
Loading

  • use vaddvq_f32 instead of vpaddq_f32 and vdups_laneq_f32 in fvec_L2sqr , fvec_inner_product , and fvec_norm_L2sqr
  • implement fvec_L1 and fvec_Linf for ARM SIMD (NEON)
    • This causes performance regression, so I've droped it.
  • implement fvec_madd and fvec_madd_and_argmin for ARM SIMD (NEON)

@wx257osn2
Copy link
Contributor Author

CondaHTTPError: HTTP 403 FORBIDDEN for url <https://conda.anaconda.org/pytorch/noarch/pytorch-mutex-1.0-cpu.tar.bz2>

😞

@wx257osn2 wx257osn2 force-pushed the improve-distances_simd_cpp-for-aarch64 branch from 37e8840 to c2eeef2 Compare July 24, 2022 21:47
@wx257osn2 wx257osn2 force-pushed the improve-distances_simd_cpp-for-aarch64 branch from c2eeef2 to 48c2848 Compare July 24, 2022 23:13
@facebook-github-bot
Copy link
Contributor

@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wx257osn2 wx257osn2 deleted the improve-distances_simd_cpp-for-aarch64 branch August 31, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wx257osn2 @facebook-github-bot