Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Fixed msvc compiler error: error C2065: 'ssize_t': undeclared identi… #1279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivlcic
Copy link

@ivlcic ivlcic commented Jun 26, 2022

Hi,

I've fixed compiler error with pip install on Windows OS.

Maybe this is not the right spot, but never the less: feel free to change.

@facebook-github-bot
Copy link
Contributor

Hi @ivlcic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ivlcic
Copy link
Author

ivlcic commented Jul 11, 2022

Fixes #1277

@DoooReyn
Copy link

Hi,

I've fixed compiler error with pip install on Windows OS.

Maybe this is not the right spot, but never the less: feel free to change.

It works. Thanks!

@T1t4m1un
Copy link

Hey @ivlcic, thanks a lot for your PR and the awesome solution to fix the problem I was facing! 🙌🎉 You rock!

By the way, I'm a bit surprised that the official team hasn't merged this patch even after a whole year. 😕 Any idea why they haven't merged it yet? It's such a valuable contribution! 🤔

Anyway, thanks again for your hard work! Let's hope we can get this patch merged soon! 🤞❤️

@ivlcic
Copy link
Author

ivlcic commented Jun 12, 2023

Any idea why they haven't merged it yet? It's such a valuable contribution!

I have no idea. Maybe it's in the wrong place or badly done. Anyway they should have fixed it already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants