Install missing build dependency for the FBPCS pce_deployment image #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: An issue was encountered that prevented build of the `pce_deployment` image against the aarch64/arm64 platform. Building the Docker image against aarch64 fails due to some missing build dependencies: `gcc`, `python3-dev`. This is because a project dependency, the `psutil` wheel, is not distributed with the aarch64 build and instead it is compiled from source (see [Wheel support for linux aarch64 · Issue facebookresearch#1782 · giampaolo/psutil · GitHub](giampaolo/psutil#1782)). This change updates the corresponding Dockerfile to install the dependencies required to compile the wheel. Reviewed By: ajaybhargavb Differential Revision: D38541052 fbshipit-source-id: 9ce75bd3016de062ba601649849840f85d881a6e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38541052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
An issue was encountered that prevented build of the
pce_deploymentimage against the aarch64/arm64 platform.Building the Docker image against aarch64 fails due to some missing build dependencies:
gcc,python3-dev. This is because a project dependency, thepsutilwheel, is not distributed with the aarch64 build and instead it is compiled from source (see Wheel support for linux aarch64 · Issue #1782 · giampaolo/psutil · GitHub).This change updates the corresponding Dockerfile to install the dependencies required to compile the wheel.
Reviewed By: ajaybhargavb
Differential Revision: D38541052