Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Removing Hard-Coded Local Paths to Data Directory #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasonyzhang
Copy link

Hi,

Thanks for the great work.

One issue is that the links to ./local_data are hard-coded which makes it very difficult to run the mocap code from a different directory than the source folder.

I committed a quick fix which is just to use the parent directory of the smpl_dir as the extra_data directory name since this required the minimum number of code changes. I think a better solution might be to take in extra_data_dir as an optional parameter for BodyMocap and HandMocap, but this may change the api a bit.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2020
@penincillin
Copy link
Contributor

@jasonyzhang
Thanks, that's a great suggestion. But we are just too busy to heavily update our code recently. We will add this updating later.
Thanks again !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants