This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Removing Hard-Coded Local Paths to Data Directory #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the great work.
One issue is that the links to ./local_data are hard-coded which makes it very difficult to run the mocap code from a different directory than the source folder.
I committed a quick fix which is just to use the parent directory of the
smpl_dir
as theextra_data directory
name since this required the minimum number of code changes. I think a better solution might be to take inextra_data_dir
as an optional parameter forBodyMocap
andHandMocap
, but this may change the api a bit.