--[BE] - Minor changes for compatibility with Eigen removal #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
11 tasks
jturner65
force-pushed
the
SimBE_EigenRefactor1
branch
from
fe19d62 to
d231ce0
Compare
|
Note, the changes to the github workflows, pointing to the Sim PR repo instead of Sim main, need to be removed before the PR is merged. |
Until the sim PR is merged, the tests on this branch will fail.
0mdc
pushed a commit
that referenced
this pull request
Jan 28, 2025
* --fix issues with change from eigen to magnum vectors * --DO NOT MERGE THIS COMMIT : test against sim PR branch instead of main. * --remove unnecessary quaternion conversions * --force positions to np arrays * --remove reference to sim PR for testing Until the sim PR is merged, the tests on this branch will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
These changes are to address the underlying sim code changing from returning eigen vector constructs to magnum vector constructs from this PR
How Has This Been Tested
Locally all python tests pass
Types of changes
LargeSmall changes to the code that improve its functionality or performanceChecklist