This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 799
Migrate Wit workflows to new data design, delete WordTaggingTask_Deprecated and WordTaggingModel #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Aug 15, 2019
geof90
force-pushed
the
export-D16827032
branch
from
August 15, 2019 19:49
c80a724
to
8ed117b
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 15, 2019
…ecated and WordTaggingModel (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 9e4af976486ac7d08d1c7dcdebfd0cb9170e4107
geof90
force-pushed
the
export-D16827032
branch
from
August 16, 2019 10:26
8ed117b
to
fcd8ad4
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: c400223c92151125b82171b0e5d7f3cb4b134215
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 60571f784199ccd27af349ccc554ff8af7975dd4
geof90
force-pushed
the
export-D16827032
branch
2 times, most recently
from
August 16, 2019 10:54
6419d78
to
3609a1a
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: a033562c89ff3578959fa7bf3eaa95e16e7b8b81
geof90
force-pushed
the
export-D16827032
branch
from
August 16, 2019 10:58
3609a1a
to
744a2be
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 2f3911f6e39ac62da54a874f5a0a4c7ff17ae1cc
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: fd9726e72eb048b11ec2c6e5c1e4ecab22c5b8a5
geof90
force-pushed
the
export-D16827032
branch
2 times, most recently
from
August 16, 2019 21:54
7998ef3
to
850c86e
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 1339aaf9713178e5f3cb02c76811abf9095e2a33
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 7d558648f59e5e1db840890d9adca4e87e56eaec
geof90
force-pushed
the
export-D16827032
branch
2 times, most recently
from
August 17, 2019 07:59
0eb4009
to
8aa937c
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 4a32a1db4c4ffe4c973efffae76cdb6b81e5c300
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: b386c9969e97b038196dc952c1d96d7765e0c5fe
geof90
force-pushed
the
export-D16827032
branch
from
August 17, 2019 08:17
8aa937c
to
c0795d5
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 713f18773b47b76be8110f6d40e1284c142a8d76
geof90
force-pushed
the
export-D16827032
branch
from
August 17, 2019 23:25
c0795d5
to
9e724f3
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Aug 18, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 08509c90b076ed94c6e45cf27a27e65b5763abd9
geof90
force-pushed
the
export-D16827032
branch
from
August 18, 2019 05:57
9e724f3
to
2d3ae67
Compare
geof90
force-pushed
the
export-D16827032
branch
from
September 3, 2019 16:40
2d3ae67
to
da46663
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 3, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: bc3a920959522608a3f115f9d813f2745cdd48f6
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 3, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 169b9cd5b5a26a3a4fadbbcfd638e7b098412578
geof90
force-pushed
the
export-D16827032
branch
2 times, most recently
from
September 5, 2019 13:27
5ab4933
to
207ed9b
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 9c3710abf1055d4102114548f487b9c79b41da4e
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 75cd72b21b9f4ed42b4378ed02ff953b1d4971fc
geof90
force-pushed
the
export-D16827032
branch
from
September 5, 2019 13:48
207ed9b
to
5b1fbda
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 3e5aa85ce72c22111ba1732b4de8b3691480118b
geof90
force-pushed
the
export-D16827032
branch
from
September 5, 2019 14:05
5b1fbda
to
203b937
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 6e0a90f7bdad2033c8e8fce35201e41fe65d3fb3
geof90
force-pushed
the
export-D16827032
branch
from
September 5, 2019 14:10
203b937
to
134bebb
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 3470b7b94a5add59673988c37110a00c397b1603
geof90
force-pushed
the
export-D16827032
branch
from
September 5, 2019 17:17
134bebb
to
fa98393
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: d6b473f9f779943bd8e0b01b7e2d8b0e4540ef6a
geof90
force-pushed
the
export-D16827032
branch
2 times, most recently
from
September 9, 2019 22:39
2949317
to
a4024c7
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 9, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: f04909143270fed2282c6f0452231b1b6a5357a6
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 10, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Differential Revision: D16827032 fbshipit-source-id: 29f9e7eebcd25accd93b39c14b3cdf6d3efcd3e9
geof90
force-pushed
the
export-D16827032
branch
from
September 10, 2019 04:19
a4024c7
to
1a6daaa
Compare
geof90
added a commit
to geof90/pytext
that referenced
this pull request
Sep 10, 2019
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Reviewed By: seayoung1112 Differential Revision: D16827032 fbshipit-source-id: c692ebcd9d6ce140229a267480e8306cabf9b9ad
geof90
force-pushed
the
export-D16827032
branch
from
September 10, 2019 17:54
1a6daaa
to
4a0d9a3
Compare
…ing tasks, models and data handlers (facebookresearch#910) Summary: Pull Request resolved: facebookresearch#910 as title Reviewed By: seayoung1112 Differential Revision: D16827032 fbshipit-source-id: 101d0c76455ad7243b4d9fdd62df9f2b6c5803a6
geof90
force-pushed
the
export-D16827032
branch
from
September 10, 2019 18:03
4a0d9a3
to
0b2a202
Compare
This pull request has been merged in ee59a74. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2019
Summary: Pull Request resolved: fairinternal/fairseq-py#910 Pull Request resolved: #1124 Pull Request resolved: facebookresearch/fairseq#1362 Split the Fariseq MemoryEfficientFP16Optimizer class into 2 classes so that it can be easily imported in pytext through a wrapper class. Iter 2 - fixed some issues to ensure code runs correctly on fblearner. Iter 3 - fixed review comments, incorrect import and lints. Iter 4 - fixed pytext test breaks. Iter 5 - fix pytext test breaks. Iter 6 - fix comments and refactor based on conversation with chenyang. Reviewed By: chenyangyu1988 Differential Revision: D18410916 fbshipit-source-id: 5238ee553cd2811ed0573825e1c29000980cc489
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title
Differential Revision: D16827032