This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix bug in copy_unk #964
Closed
Fix bug in copy_unk #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: facebookresearch#964 When the copy_unk flag is set to true. Any unk that is produced in the output of the Seq2Seq model is replaced by the token that was mapped to unk from the utterance. This is a easy way to get gains since outputs with unk are always wrong. Looking at the old code for copying the unk token we see that TorchScript optimizes out the actual search of the unk token in utterance: {F207887831} This diff updates the code to produce the correct TorchScript Graph {F207888470} Reviewed By: arbabu123 Differential Revision: D17213086 fbshipit-source-id: 9f02f7dddf79671e96feb28b0581ded504cb69fc
ArmenAg
force-pushed
the
export-D17213086
branch
from
c971b2b to
b1f8471
Compare
|
This pull request has been merged in b362c31. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the copy_unk flag is set to true. Any unk that is produced in the output of the Seq2Seq model is replaced by the token that was mapped to unk from the utterance. This is a easy way to get gains since outputs with unk are always wrong.
Looking at the old code for copying the unk token we see that TorchScript optimizes out the actual search of the unk token in utterance:
{F207887831}
This diff updates the code to produce the correct TorchScript Graph
{F207888470}
Differential Revision: D17213086