Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Causal mask is skipped if no att_mask is passed #103

Closed
blefaudeux opened this issue Nov 15, 2021 · 2 comments · Fixed by #104
Closed

[bug] Causal mask is skipped if no att_mask is passed #103

blefaudeux opened this issue Nov 15, 2021 · 2 comments · Fixed by #104

Comments

@blefaudeux
Copy link
Contributor

🐛 Bug

In https://github.com/facebookresearch/xformers/blob/main/xformers/components/attention/scaled_dot_product.py#L78
if no att_mask is passed, then an hypothetical causal mask is completely skipped
@blefaudeux
Copy link
Contributor Author

cc @SeanNaren, thanks for the heads up, fixing that asap

@blefaudeux
Copy link
Contributor Author

cc @dianaml0, maybe the reason why you were having a trouble comparing dense and blocksparse ? This was pretty wrong

@blefaudeux blefaudeux mentioned this issue Nov 15, 2021
Merged
10 tasks
xwhan pushed a commit to xwhan/xformers that referenced this issue Feb 8, 2022
@blefaudeux
[minor] test block factory on device, faster unit tests (facebookrese…
110889b 
…arch#103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] Causal mask being skipped if no extra mask facebookresearch/xformers
1 participant
@blefaudeux