[bugfix][Favor] Same feature map for q and k #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
blefaudeux
force-pushed
the
favor_proj_bugfix
branch
from
f3b613c to
5ff7137
Compare
blefaudeux
force-pushed
the
favor_proj_bugfix
branch
from
5ff7137 to
fff320d
Compare
fmassa
reviewed
Jan 18, 2022
| @@ -98,8 +98,7 @@ def __init__( | |||
| "normalize_inputs": self.normalize_inputs, | |||
| } | |||
|
|
|||
| self.feature_map_query: FeatureMap = feature_map_constructor(**feature_settings) # type: ignore | |||
| self.feature_map_key: FeatureMap = feature_map_constructor(**feature_settings) # type: ignore | |||
| self.feature_map: FeatureMap = feature_map_constructor(**feature_settings) # type: ignore | |||
There was a problem hiding this comment.
We should probably enforce now that the iter_before_redraw is a multiple of 2, or multiply it by 2 in the implementation of the FeatureMap, otherwise we can still sample different maps for k / q
There was a problem hiding this comment.
oww, that would have been an annoying bug, great catch and I went too fast. I would do a x2 on the setting, because I think that from the outside "iter" means "number of steps we took"
There was a problem hiding this comment.
I updated the docstring for the attention to make it clear that this counted the number of "forward" calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Thanks @fmassa for the heads up !
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.