Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Partial Fix] Model pickability #204

Merged
merged 2 commits into from
Feb 4, 2022
Merged

[Partial Fix] Model pickability #204

merged 2 commits into from
Feb 4, 2022

Conversation

blefaudeux
Copy link
Contributor

@blefaudeux blefaudeux commented Feb 3, 2022

What does this PR do?

Touches #203, but not for all configurations for now

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2022
@blefaudeux
Copy link
Contributor Author

cc @jramapuram

@codecov-commenter
Copy link

Codecov Report

Merging #204 (bdc05b3) into main (093224e) will increase coverage by 0.10%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   91.52%   91.62%   +0.10%     
==========================================
  Files          59       59              
  Lines        2996     2998       +2     
==========================================
+ Hits         2742     2747       +5     
+ Misses        254      251       -3     
Flag Coverage Δ
Python 91.62% <80.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xformers/components/in_proj_container.py 76.31% <75.00%> (+1.99%) ⬆️
xformers/components/attention/blocksparse.py 94.20% <100.00%> (ø)
...rmers/components/feedforward/mixture_of_experts.py 92.42% <100.00%> (ø)
xformers/factory/block_factory.py 93.93% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093224e...bdc05b3. Read the comment docs.

@blefaudeux blefaudeux changed the title [DRAFT][Fix] Model pickability Fix] Model pickability Feb 4, 2022
@blefaudeux
Copy link
Contributor Author

Submitting this for review already, and I'll try to find a solution for the triton parts in another PR

@blefaudeux blefaudeux changed the title Fix] Model pickability [Partial Fix] Model pickability Feb 4, 2022
@blefaudeux blefaudeux merged commit 8008a3f into main Feb 4, 2022
@jramapuram
Copy link

Many thanks @blefaudeux ! Appreciate the quick fix!

xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
…tch-1

Move scaling prior to matrix multiplication
@blefaudeux blefaudeux deleted the pickling_tests branch February 9, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants