-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Partial Fix] Model pickability #204
Conversation
562047f
to
5c980bb
Compare
cc @jramapuram |
5c980bb
to
bdc05b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 91.52% 91.62% +0.10%
==========================================
Files 59 59
Lines 2996 2998 +2
==========================================
+ Hits 2742 2747 +5
+ Misses 254 251 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Submitting this for review already, and I'll try to find a solution for the triton parts in another PR |
Many thanks @blefaudeux ! Appreciate the quick fix! |
…tch-1 Move scaling prior to matrix multiplication
What does this PR do?
Touches #203, but not for all configurations for now
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.