Add nd-tensor support for triton softmax #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
LGTM, but could you just add one more shape here ? https://github.com/facebookresearch/xformers/blob/main/tests/test_triton_softmax.py#L24 This would cover this case, better safe than sorry :) |
blefaudeux
approved these changes
Feb 7, 2022
blefaudeux
reviewed
Feb 7, 2022
| @@ -28,6 +28,8 @@ | |||
| (1, 2048, 2048), | |||
| (1, 3136, 3136), | |||
| (1, 4096, 4096), | |||
| (2, 2, 384, 384), | |||
blefaudeux
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR generalizes
xformers.triton.softmaxto support tensors of more than 3 dimensions.It does it by flattening the input so that it is 3d.
A similar patch was already added in the past so that it supports 2d tensors, so this is follows in a similar way.
I can add more tests if needed