Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I don't think that fixes #219, but related (init not properly done). Caught when implementing #227, I think that we would need to add a proper explicit/programable init to the model factory to rule out any issue there.
In the meantime this must have been a typo, I'm not sure when it slipped in but does not make a lot of sense (biases are typically zero-init but linear weights are one-init for instance, this line would nuke that). This PR makes sure that by default the init values defined by the components are preserved
cc @jramapuram
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.