Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocksparse switch revisions #342

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Blocksparse switch revisions #342

merged 3 commits into from
Jun 27, 2022

Conversation

yuanandonly
Copy link
Contributor

What does this PR do?

Adds minor changes to #334

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2022
dianaml0
dianaml0 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@dianaml0 dianaml0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@yuanandonly yuanandonly merged commit 12e8abc into main Jun 27, 2022
@yuanandonly yuanandonly deleted the causal_auto_sparse_rev branch June 27, 2022 17:21
blefaudeux pushed a commit that referenced this pull request Jul 8, 2022
@lisjin
[T104292598] Refactor the "LRA" training code -> Pytorch Lightning (#343
769cfe3 
)

* First attempt at PL trainer

* Blocksparse switch revisions (#342)

* minor cleanup; updated changelog

* fixed mypy error

* added checking for blocksparse availability

Co-authored-by: Chris Yuan <christopheryuan@learnfair1490.h2.fair>
Co-authored-by: Chris Yuan <christopheryuan@devfair0278.h2.fair>

* Finish PL refactor

* Fix coding style, remove unused imports

* Fix flake8 error

* Make isort happy

* Let pre-commit handle formatting...

* Add type hints, fix eval behavior

* Evaluate PL refactor with batch_submit.py

Co-authored-by: Chris Yuan <christopheryuan@learnfair1490.h2.fair>
Co-authored-by: Chris Yuan <christopheryuan@devfair0278.h2.fair>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianaml0 dianaml0 dianaml0 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanandonly @dianaml0 @facebook-github-bot