[chore][DRAFT] Updating triton to a recent release #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a basic triton random check updating the plots to a more representative GPU (A6000) and new triton package (no tuning)
blefaudeux
force-pushed
the
triton_update
branch
from
6f6b9be
to
c4ab454
Compare
facebook-github-bot
added
the
CLA Signed
|
the (relative to pytorch) perf regressed on the dropout case, I used a more straightforward code but it looks like it had an impact, I'll fix that |
blefaudeux
changed the title
|
linear layers must be updated in a similar fashion as dropout, closing the PR and reopening when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump up the triton package that xformers works against, to track the changes there. There were some syntax changes which required fixes in the dropout layer. I'm hoping that this fixes some bf16 issues which were visible for some layers some time ago
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.