bwinline: Forceinline all functions of the bw #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 3, 2022
ghstack-source-id: ad077080cb8cfef645610b2bfbac9def4ef6e179 Pull Request resolved: #453
facebook-github-bot
added
the
CLA Signed
Codecov ReportBase: 91.39% // Head: 91.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## gh/danthe3rd/44/base #453 +/- ##
=====================================================
Coverage 91.39% 91.39%
=====================================================
Files 75 75
Lines 4417 4417
=====================================================
Hits 4037 4037
Misses 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Oct 5, 2022
fmassa
approved these changes
Oct 5, 2022
Comment on lines
+114
to
+129
| head_dim = warp_uniform(head_dim); | ||
| head_dim_value = warp_uniform(head_dim_value); | ||
| num_queries = warp_uniform(num_queries); | ||
| num_keys = warp_uniform(num_keys); | ||
|
|
||
| query_ptr = warp_uniform(query_ptr); | ||
| key_ptr = warp_uniform(key_ptr); | ||
| value_ptr = warp_uniform(value_ptr); | ||
| logsumexp_ptr = warp_uniform(logsumexp_ptr); | ||
| output_ptr = warp_uniform(output_ptr); | ||
| grad_output_ptr = warp_uniform(grad_output_ptr); | ||
| delta_ptr = warp_uniform(delta_ptr); | ||
|
|
||
| grad_query_ptr = warp_uniform(grad_query_ptr); | ||
| grad_key_ptr = warp_uniform(grad_key_ptr); | ||
| grad_value_ptr = warp_uniform(grad_value_ptr); |
There was a problem hiding this comment.
note to self: this trick is needed otherwise there would be a performance slowdown
danthe3rd
pushed a commit
that referenced
this pull request
Oct 6, 2022
ghstack-source-id: ad077080cb8cfef645610b2bfbac9def4ef6e179 Pull Request resolved: #453
bertmaher
pushed a commit
to bertmaher/xformers
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):