Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on Python 3.7 unpacking tuple in return statements #541

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

susumuota
Copy link
Contributor

@susumuota susumuota commented Nov 25, 2022

What does this PR do?

On Python 3.7.15 (current Google Colab), #527 still raise SyntexError.

  File "/usr/local/lib/python3.7/dist-packages/xformers/ops/unbind.py", line 99
    return None, *(grad.unbind(dim=ctx.dim))
                 ^
SyntaxError: invalid syntax

According to these info,

It is a matter of the "return statement", not only unpacking things. So it should be,

        return (None, *grad.unbind(dim=ctx.dim))

I confirmed this fix works on 3.7.15.

It was discussed at 0428e12#r91033157

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2022
Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Will merge once the tests pass

@susumuota susumuota changed the title fix error about Python 3.7 unpacking tuple in return statements fix error on Python 3.7 unpacking tuple in return statements Nov 25, 2022
@danthe3rd danthe3rd merged commit a67de13 into facebookresearch:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants