-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Wheels to PyPi #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks a lot for putting this together!
Just requested a minor change in the version numbering
.github/workflows/wheels.yml
Outdated
echo "BUILD_VERSION=$version$num_commits" >> ${GITHUB_ENV} | ||
cat ${GITHUB_ENV} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should have a system a bit different on pip than conda. We should use pre-releases (eg 0.0.16rc{num_commits}), so that by default, "pip install -U xformers" will install the latest tagged version (0.0.15).
If the user wants a potential unstable pre-release, they should ask for it explicitly ("pip install -U --pre xformers").
What do you think?
It might make things easier to remove the ".dev" suffix from the version.txt
file, and instead add it manually where it is needed.
Also we should probably also have a source-distribution, but we can worry about that later |
@danthe3rd I have added the requested changes. Example Publish: |
Thanks! Just a last thing - it should be a release candidate for the next version (0.0.16rcXXX here) |
@danthe3rd so do you mean I should update the |
Keep version.txt as it is, but when we build for a RC, increment version by 1 |
@danthe3rd I took the easiest path and wrote a python script that generates the version. I didn't want to hack around with bash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect - thanks a lot! Let's get this merged once we have greenlights from CI :)
Let's merge :) |
Related #533 #573 #532 #534 #523 #473 (damn, this is getting out of hand).
A few decisions here:
dev
(notrc
) to stay consistent with condaExample run:
https://github.com/AbdBarho/xformers-wheels/actions/runs/3689261975
Published Wheels:
https://test.pypi.org/project/formers/0.0.15.dev376/#files
TODO (for future PRs):