Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Cleaner Nystrom masking (just discovered triu) #79

Merged
merged 1 commit into from
Nov 5, 2021
Merged

[minor] Cleaner Nystrom masking (just discovered triu) #79

merged 1 commit into from
Nov 5, 2021

Conversation

blefaudeux
Copy link
Contributor

What does this PR do?

Same as before, it's just that I discovered triu (upper triangular) in the meantime, I always believed that there was only tril (lowertri) so the code was generating a tril and transposing things

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2021
@blefaudeux blefaudeux merged commit 1f22932 into main Nov 5, 2021
@blefaudeux blefaudeux deleted the minor_nystrom_triu branch November 5, 2021 16:45
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@fmassa
Fix gaussian distribution and sampling for large number of categories (…
9f2110a 
…facebookresearch#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianaml0 dianaml0 dianaml0 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blefaudeux @dianaml0 @facebook-github-bot