Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update merge_masks to work for additive attention mask #86

Merged
merged 1 commit into from
Nov 9, 2021
Merged

update merge_masks to work for additive attention mask #86

merged 1 commit into from
Nov 9, 2021

Conversation

dianaml0
Copy link
Contributor

@dianaml0 dianaml0 commented Nov 8, 2021

What does this PR do?

update merge_masks to work for additive attention mask

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2021
blefaudeux
blefaudeux approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@blefaudeux blefaudeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@blefaudeux blefaudeux merged commit cf46d43 into main Nov 9, 2021
@dianaml0 dianaml0 deleted the diana_update branch November 23, 2021 21:01
xwhan pushed a commit to xwhan/xformers that referenced this pull request Feb 8, 2022
@blefaudeux
[ci][fix] run attention test on gpu if available (facebookresearch#86)
3196746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blefaudeux blefaudeux blefaudeux approved these changes

@fmassa fmassa Awaiting requested review from fmassa

@jieru-hu jieru-hu Awaiting requested review from jieru-hu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianaml0 @blefaudeux @facebook-github-bot