Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Zsh style *** #225

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Add support for Zsh style *** #225

merged 6 commits into from
Sep 26, 2024

Conversation

facelessuser
Copy link
Owner

Resolves #224

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: glob Glob library. C: pathlib Pathlib library. C: pattern-parser Related to pattern parsing. C: source Related to source code. labels Sep 26, 2024
@facelessuser
Copy link
Owner Author

facelessuser commented Sep 26, 2024 •
edited
Loading

Need to test:

  • glob
  • globmatch
  • pathlib.match
  • pathlib.rglob
  • Ensure ** does not match symliks and *** does, even if FOLLOW is enabled.
  • Ensure GLOBSTAR is enabled with GLOBSTARLONG
  • Ensure FOLLOW affects MATCHBASE properly when enabled with GLOBSTARLONG
  • Ensure FOLLOW affects pathlib.match properly when enabled with GLOBSTARLONG
  • Ensure FOLLOW affects pathlib.rglob properly when enabled with GLOBSTARLONG

@gir-bot gir-bot added the C: tests Related to testing. label Sep 26, 2024
@gir-bot gir-bot added the C: fnmatch Fnmatch library. label Sep 26, 2024
@facelessuser
Add pathlib tests and fix some issues
ff306c1 
- Add missing `PurePath.full_match` method that redirects to
  `PurePath.globmatch`.
- `PurePath.match` should respect hidden file rules and symlink rules
  the same as `rglob`. `match` matches what `rglob` globs.
@facelessuser
Fix mypy Python 3.13
bb29bb7
@facelessuser facelessuser marked this pull request as ready for review September 26, 2024 17:54
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Sep 26, 2024
@facelessuser facelessuser merged commit 0c069cb into main Sep 26, 2024
17 checks passed
@facelessuser facelessuser deleted the feature/globstarlong branch September 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: docs Related to documentation. C: fnmatch Fnmatch library. C: glob Glob library. C: pathlib Pathlib library. C: pattern-parser Related to pattern parsing. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ***, zsh style globstar that recurse symlinks
2 participants
@facelessuser @gir-bot