feat: v2 LTS Release #287
Merged
feat: v2 LTS Release #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… params + fix double dispatch o
`onAfterChange` is erroneously called when a routethunk dispatches a redirect action - this can cause some undesired logic to executue. This detects redirect actions in the executed routeThunks, and appropriately skips `onAfterChange` in that event. #96
… formalized thunk contract + ca
…ction + extra keys. the "extra" key/val is the same as an "extra" option you provide to connect routes. I.e. the equivalent of redux-thunk's extra argument.
…memoryHistory + your forks/impl
Fixes for SEO with basename
…ptions provided BREAKING CHANGE: path segments that are numbers will now be passed to to/fromPath
fix($thunks): Skip `onAfterChange` when route thunks dispatch a redirect
…on reducer in NOT_FOUND actions 175
|
Interestingly, the CI doesn't run codeclimate on that branch |
|
#290 pulls in the latest documentation fixes from master |
…GoBack and canGoForward
Ignore vulnerabilities detected by skyk that exist in development only
Merge the latest master into rudy
Fix crash in canGoBack and canGoForward
Integer coercion fix for Rudy
|
Might be worth looking at the latest comments here #41 (comment) by @dawnmist - looks like the integer coersion issue is not fully fixed. |
|
Thanks man , will do |
feat: Pre-release fixes
# Conflicts: # .snyk # README.md # docs/connectRoutes.md # package.json # src/pure-utils/pathToAction.js # yarn.lock
# Conflicts: # .snyk # README.md # docs/connectRoutes.md # package.json # src/pure-utils/pathToAction.js # yarn.lock
|
Preparing to release this, working on failing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moderate update of react-first-router.
This is an early version of
rudywhich will be superseded byrudy-respondwhich is a complete rewrite.This release is designed to being a handful of fixes to redux-first-router, while attempting to keep the api the same as well as suppress breaking changes.
Too much has changed in here, and before my time on this project. The docs will be your friend on this one!
Fixes: #276 #285