Add option: resettable #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to Symfony 5.3, I encountered a strange bug regarding this transport, which started being empty all of a sudden.
Reason behind it was that this transport implents the
ResetInterface, which is invoked when the shutdown of the kernel is enforced during tests or when starting a KernelBrowser. This flushed the whole transport, which was undesired.This PR add a parent to the transport that still has the method, but doesn't implement the interface, to avoid forced calls to that method. It also adds a
resettableoption that defaults totrueso that this behavior is customizable, but there's no BC.Possible future scope: reverse the default in a new major version, change the parent into a child to have better naming (
MongoDbResettableTransport).