Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn unfds/refds into internal (unexported) S3 generics #36

Open
lianos opened this issue May 21, 2020 · 0 comments
Open

Turn unfds/refds into internal (unexported) S3 generics #36

lianos opened this issue May 21, 2020 · 0 comments
Assignees
@lianos
Labels
enhancement New feature or request

Comments

@lianos
Copy link
Member

lianos commented May 21, 2020

For some reason I had a problem using internal s3 generics while running testthat.

It may have been because it was 2am when I resigned to just exporting, but worth putting this on the radar for a later spring cleaning.
@lianos lianos added the enhancement New feature or request label May 21, 2020
@lianos lianos self-assigned this May 21, 2020
lianos pushed a commit that referenced this issue May 21, 2020
Adds support for serialization of FacileAnalysis results via fsave/fl…
9816772 
…oad.

This implementation is rudimentary but seems to work.

Come back to Issue #36 to see about not exporting unfds/refds when you
have some time, won't you? Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lianos lianos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lianos