Add parsing support for tsl messages #1043
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // is not relevant inside plotjuggler any more | ||
| std::uint32_t sec = _deserializer->deserializeUInt32(); // stamp | ||
| std::uint32_t nsec = _deserializer->deserializeUInt32(); // stamp | ||
| std::size_t definition_hash = |
Check notice
Code scanning / CodeQL
Unused local variable Note
| std::uint32_t sec = _deserializer->deserializeUInt32(); // stamp | ||
| std::uint32_t nsec = _deserializer->deserializeUInt32(); // stamp | ||
| std::size_t definition_hash = | ||
| _deserializer->deserialize(BuiltinType::UINT64).extract<std::size_t>(); |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
|
||
| std::size_t num_signals = 0; | ||
| std::size_t index = 0; | ||
| for (auto const& _ : _tsl_type_order) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| } | ||
| void ParserROS::parseTSLValues(const std::string& prefix, double& timestamp) | ||
| { | ||
| // region Deserialize into a flattened array of double values since the type |
Check notice
Code scanning / CodeQL
Unused local variable Note
| void ParserROS::parseTSLValues(const std::string& prefix, double& timestamp) | ||
| { | ||
| // region Deserialize into a flattened array of double values since the type | ||
| // is not relevant inside plotjuggler any more |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
Regarding the comments: |
We at TUM Autonomous Motorsport developed our own time series logging library - comparable to Data Tamer and pal_statistics. By the way, Kudos to DataTamer, it's an awesome library.
However, we already started developing our library before DataTamer was around.
And even then, it did unfortunately not fit all the requirements we had (e.g. access from python....).
Our library called TSL is now also OpenSource.
Therefore, I would really like it if the message definitions were supported officially by PlotJuggler and not just by our fork.
Let me know what you think of the PR. For the implementation of the message parsing, I have oriented myself on your implementation of the pal_statistics and data tamer parser. The implementation has been tested for months internally without any problems.