-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #73
Conversation
Coverage reportBranches coverage not met for global: expected >=80%, but got 70.51282051282051%
Test suite run success34 tests passing in 11 suites. Report generated by 🧪jest coverage report action from f53e282 |
…tiverse/storybook-design-system into feature/ttykvart-update-dependencies
.storybook/main.js
Outdated
@@ -12,7 +13,6 @@ module.exports = { | |||
|
|||
// Community addons | |||
'storybook-mobile', | |||
'storybook-addon-mdx-embed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused dependency.
@@ -1,5 +1,6 @@ | |||
module.exports = { | |||
stories: ['../src/**/*.stories.@(js|jsx|ts|tsx|mdx)'], | |||
staticDirs: ['../public'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the static directory in package.json
was deprecated, it has to be set here instead.
@@ -0,0 +1 @@ | |||
legacy-peer-deps=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary fix for node v8.6.
@@ -34,7 +34,6 @@ | |||
"jest/no-identical-title": "error", | |||
"jest/prefer-to-have-length": "warn", | |||
"jest/valid-expect": "error", | |||
"valid-jsdoc": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing jsdoc, has been mostly unused and we can document components in better ways.
@@ -15,11 +15,11 @@ | |||
"homepage": "https://github.com/factiverse/storybook-design-system#readme", | |||
"scripts": { | |||
"generate": "node ./util/create-component", | |||
"storybook": "start-storybook -p 6006 -s public", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated, see above.
"chromatic": "npx chromatic --project-token=e8130cbb59b8 --exit-once-uploaded", | ||
"deploy-storybook": "storybook-to-ghpages", | ||
"deploy": "storybook-to-ghpages", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy command deploys to GitHub pages in other repos, should be called the same here.
@@ -76,17 +76,10 @@ | |||
"main": "build/index.js", | |||
"module": "build/esm/index.js", | |||
"types": "build/index.d.ts", | |||
"overrides": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the unnecessary dependency mdx-embed.
# Conflicts: # .eslintrc # .storybook/main.js # package-lock.json # src/stories/Introduction.stories.mdx
Is this PR still valid with the changes? |
Keeping the dependencies up to date and removed some unused/unnecessary packages.