Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Gallery #443

Closed
wants to merge 3 commits into from
Closed

Widget Gallery #443

wants to merge 3 commits into from

Conversation

dani-moreno
Copy link
Collaborator

Adds Widget Gallery, a layout component designed to display multiple widgets together in a grid, with the option to showcase a widget at full width.

This is a pretty simple implementation that can be expanded as needed. Some teams are already designing widgets using a grid layout, so this is just the first step toward implementing those designs.

image

Copy link

github-actions bot commented Aug 26, 2024

🔍 Visual review for your branch is published 🔍

Here are the links to:

@dani-moreno dani-moreno marked this pull request as ready for review August 26, 2024 15:02
@dani-moreno dani-moreno requested a review from a team as a code owner August 26, 2024 15:02
@dani-moreno dani-moreno marked this pull request as draft August 28, 2024 08:46
Copy link
Collaborator

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, really like it!

export const FullWidth: Story = {
args: {
children: [
<AreaChartWidget {...AreaChartWidgetStoriesMeta.args} data-full-width />,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach! Did you come up with the idea or have you read this somewhere? I like that it's decoupled from the widgets, so it can potentially be used with other compatible components ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants