Fixed code and unit tests #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbigman
commented
Jul 26, 2023
jbigman
commented
- fixed search: more section title is not always empty, it can contain "Apps"
- fixed missing comments (ds:9 => ds:8)
- new url called to test throttle,
- updated expected results
- fixed search: more section title is not always empty, it can contain "Apps" - fixed missing comments (ds:9 => ds:8) - new url called to test throttle, - updated expected results
…will answer quickly
This was referenced Jul 27, 2023
test/lib.search.js
Outdated
| return gplay.search({ term: 'netflix' }) | ||
| .then((apps) => { | ||
| console.log(apps.map((app) => app.appId)); |
There was a problem hiding this comment.
Don't leave console logs in the code
test/lib.search.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should return few netflix apps from german store with german language', () => { | ||
| return gplay.search({ term: 'netflix', lang: 'de', country: 'DE' }) | ||
| .then((apps) => { | ||
| console.log(apps.map((app) => app.appId)); |
|
I don't know why the throttle tests are timing out here, the build passed at my fork. |
|
Seems to fail consistently... I'll merge this anyway as it's an improvement from the current code, but we should try to figure out why it doesn't pass. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.