Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esm migration #651

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Esm migration #651

merged 6 commits into from
Aug 7, 2023

Conversation

jbigman
Copy link
Contributor

@jbigman jbigman commented Aug 4, 2023 •
edited
Loading

I followed your advice and kept the usage of R from 'ramda' instead of direct module function imports.
For cheerio imports, it is a bit different because of @deprecated warning :

/**
 * The default cheerio instance.
 *
 * @deprecated Use the function returned by `load` instead.
 */

facundoolano
facundoolano reviewed Aug 6, 2023
View reviewed changes
lib/categories.js Outdated Show resolved Hide resolved
facundoolano
facundoolano reviewed Aug 6, 2023
View reviewed changes
lib/app.js Outdated Show resolved Hide resolved
facundoolano
facundoolano requested changes Aug 6, 2023
View reviewed changes
Copy link
Owner

@facundoolano facundoolano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of change requests.

Also, you should update the README, since most examples are still using require (that won't be supported anymore right?)

This was referenced Aug 6, 2023
Closed
Closed
facundoolano
facundoolano reviewed Aug 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
facundoolano
facundoolano approved these changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@facundoolano facundoolano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@facundoolano
Copy link
Owner

this one closes #632

@facundoolano facundoolano merged commit b0ffa3e into facundoolano:main Aug 7, 2023
3 checks passed
@facundoolano facundoolano mentioned this pull request Aug 7, 2023
Closed
@facundoolano
Copy link
Owner

@jbigman just merged, feel free to send a separate PR with library bumps and I'll publish a major version after that.

@jbigman jbigman deleted the esm-migration branch August 7, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundoolano facundoolano facundoolano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbigman @facundoolano