Fix variable number of reviews returned #676 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 7, 2024 12:25
|
All fails appear to be apps that have been removed from store - |
facundoolano
reviewed
Apr 7, 2024
|
this LGTM. perhaps you can extend the pagination related test to check that the same query returns the same results every time (ideally this would be failing in main and would be fixed by this change) |
For detection of facundoolano#676 (less than actual number of requests returned, different response count on each request). Using app with large number of reviews sorted by helpfulness (assuming this set does not change as frequently as just reviews), num: 1500 is reasonably fast and we get 2 x 10 paged requests (of 150 results) that ought to prove paging works.
|
Good point - added test that utilises built-in paging, fails on main and works with cookies. As several other tests fail due to discontinued apps ... com.facebook.katana will hopefully stay up for some time and considering the number of reviews perhaps the set of 1500 most helpful ones does not change too often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #676 reviews (and presumably other listings) that require pagination are returning inconsistent results. Implementing cookieJar appears to fix that.
Not tested with other functions.