dynamically resolves comments path #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundoolano
reviewed
Aug 8, 2024
jonathansampson
force-pushed
the
resolve-comments-path
branch
from
a702022
to
afdef2a
Compare
Comments may be found in either ds:8 or ds:9 paths. This approach will check for expected fields in both paths before determine which path houses the comments themselves.
jonathansampson
force-pushed
the
resolve-comments-path
branch
from
afdef2a
to
0ffe549
Compare
|
Looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing in part due to an inability to resolve the proper comments path. This is a step towards resolving test issues.
fixes #682