Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduces support for shortDescription #688

Closed
wants to merge 1 commit into from
Closed

introduces support for shortDescription #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Results:
title: 'Google Translate',
description: 'Translate between 103 languages by typing\r\n...' ,
descriptionHTML: 'Translate between 103 languages by typing<br>...',
shortDescription: 'The world is closer than ever with over 100 languages',
summary: 'The world is closer than ever with over 100 languages',
installs: '500,000,000+',
minInstalls: 500000000,
Expand Down
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ export interface IAppItemFullDetail extends IAppItem {
title: string
description: string
descriptionHTML: string
shortDescription: string
summary: string
installs: string
minInstalls: number
Expand Down
1 change: 1 addition & 0 deletions lib/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const MAPPINGS = {
path: ['ds:5', 1, 2],
fun: helper.descriptionHtmlLocalized
},
shortDescription: ['ds:5', 1, 2, 73, 0, 1],
jonathansampson marked this conversation as resolved.
Show resolved Hide resolved
summary: ['ds:5', 1, 2, 73, 0, 1],
installs: ['ds:5', 1, 2, 13, 0],
minInstalls: ['ds:5', 1, 2, 13, 1],
Expand Down
1 change: 1 addition & 0 deletions test/lib.app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const validateAppDetails = (app) => {
assert.isString(app.summary);
assert.isString(app.description);
assert.isString(app.descriptionHTML);
assert.isString(app.shortDescription);
assert.isString(app.released);
assert.equal(app.genreId, 'GAME_PUZZLE');

Expand Down
Loading