Prevent undefined shift intrinsics from being used when R128_STDC_ONLY is defined
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LY` is defined `R128_STDC_ONLY` causes intrinsic headers to not be included. It can be defined manually (via build options) even on systems where those intrinsics are available. This patch takes care of a case where only the availability of the intrinsic is checked, and not whether it's force-disabled by `R128_STDC_ONLY`.
|
Good catch. Thank you for the fix. |
shana
added a commit
to shana/godot
that referenced
this pull request
Nov 6, 2023
…luded. fahickman/r128#15 is needed to build on platforms that define R128_STDC_ONLY
YuriSizov
pushed a commit
to YuriSizov/godot
that referenced
this pull request
Jan 23, 2024
…luded. fahickman/r128#15 is needed to build on platforms that define R128_STDC_ONLY (cherry picked from commit 8fad157)
GuybrushThreepwood-GitHub
pushed a commit
to GuybrushThreepwood-GitHub/godot
that referenced
this pull request
Jan 27, 2024
…luded. fahickman/r128#15 is needed to build on platforms that define R128_STDC_ONLY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R128_STDC_ONLYcauses intrinsic headers to not be included. It can be defined manually (via build options) even on systems where those intrinsics are available. This patch takes care of a case where only the availability of the intrinsic is checked, and not whether it's force-disabled byR128_STDC_ONLY.