Skip to content

Commit

Permalink
Remove non-working call to blocks->ports->publishPendingTags
Browse files Browse the repository at this point in the history
The call was calling the method on the scheduler itself instead of on
the blocks it was iterating over. This was probably an incomplete
refactoring in moving this functionality from the block to the
Scheduler. Since then the tag handling was changed considerably, so that
in the meantime this line can be safely removed.

Thanks to @mattkretz for spotting this and starting the initial
investigation.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
  • Loading branch information
wirew0rm committed Sep 30, 2024
1 parent f94b029 commit 49a96f8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/include/gnuradio-4.0/Scheduler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ class SchedulerBase : public Block<Derived> {
std::lock_guard lock(_jobListsMutex);
_graph.forEachBlockMutable([this](auto& block) {
this->emitErrorMessageIfAny("LifecycleState -> RUNNING", block.changeState(lifecycle::RUNNING));
for_each_port([](auto& port) { port.publishPendingTags(); }, outputPorts<PortType::STREAM>(this));
});
if constexpr (executionPolicy() == ExecutionPolicy::singleThreaded || executionPolicy() == ExecutionPolicy::singleThreadedBlocking) {
assert(_nRunningJobs.load(std::memory_order_acquire) == 0UZ);
Expand Down

0 comments on commit 49a96f8

Please sign in to comment.