Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test fails, switch off fsanitize=address for emscriptem. #175

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Fix test fails, switch off fsanitize=address for emscriptem. #175

merged 1 commit into from
Sep 30, 2023

Conversation

drslebedev
Copy link
Contributor

@drslebedev drslebedev commented Sep 29, 2023 •
edited
Loading

Fix test fails. It seems that -fsanitize=address flag causes that too many locals are created.
For the moment just do not use -fsanitize=address flag for emscriptem.

@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:13 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:14 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:15 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@drslebedev drslebedev temporarily deployed to configure coverage September 29, 2023 20:54 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

RalphSteinhagen
RalphSteinhagen approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally disabling warnings/sanitizers would be a workaround but since this is on for the other gcc/clang cases this is OK. Thanks @drslebedev for looking into this. 😀

@RalphSteinhagen RalphSteinhagen merged commit c61fdf3 into main Sep 30, 2023
17 of 19 checks passed
@drslebedev drslebedev mentioned this pull request Sep 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drslebedev @RalphSteinhagen