Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Block to handle SyncInput-AsyncOutput ports case. #366

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Change Block to handle SyncInput-AsyncOutput ports case. #366

merged 1 commit into from
Jun 21, 2024

Conversation

drslebedev
Copy link
Contributor

@drslebedev drslebedev commented Jun 20, 2024 •
edited
Loading

The PR includes the following changes:

  1. Modify Block class to manage SyncInput-AsyncOutput ports cases.
  2. Add SyncOrAsync unit test to cover various scenarios of sync/async input/output ports.
  3. Update qa_Tags expected values; the default policy now drops epilogue samples.

@drslebedev drslebedev marked this pull request as draft June 20, 2024 12:49
@drslebedev
Change Block to handle SyncInput-AsyncOutput ports case.
a4b7ce1 
Signed-off-by: drslebedev <dr.s.lebedev@gmail.com>
@drslebedev drslebedev marked this pull request as ready for review June 21, 2024 10:29
@wirew0rm wirew0rm mentioned this pull request Jun 21, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@RalphSteinhagen RalphSteinhagen merged commit 78ff80a into main Jun 21, 2024
9 of 10 checks passed
@RalphSteinhagen RalphSteinhagen deleted the fix_async branch June 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drslebedev @RalphSteinhagen