Update vir simd 0.4 #404
Merged
Update vir simd 0.4 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkretz
force-pushed
the
update-vir-simd-0.4
branch
from
a2b82c2
to
7b40e2d
Compare
mattkretz
force-pushed
the
update-vir-simd-0.4
branch
7 times, most recently
from
88786a7
to
6751f88
Compare
Only convert simd types that are supported by the implementation. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
mattkretz
force-pushed
the
update-vir-simd-0.4
branch
5 times, most recently
from
3535e26
to
a785060
Compare
* Bump to vir-simd v0.4.0 * Replace gr::meta::simdize with vir::simdize. * Replace gr::meta::simdize_size_v with ::size() on simdized types. * "Document" that vir::transform can be used, where std::transform and std::ranges::transform are documented. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
Remove: - invokeProcessOneWithOrWithoutOffset - exact_argument_type - can_processOne_with_offset_invoke_test - can_processOne_simd_with_offset - can_processOne_scalar_with_offset - can_processOne_with_offset Modify MergedGraph apply_left, apply_right, processOne, and processOne_simd to not require an offset argument anymore. Modify all calls to processOne(_simd) to never pass an offset. Modify TagMonitors processOne to generateTag without offset. The published tag is now unconditional 0 all the time. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
Either the function is const and can work with chunks of inputs, or it is non-const and cannot work with chunks of input. These functions were none of these. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
With `sink::processOne` being non-const the merged graphs in this benchmark are always non-SIMD. Consequently the processOne_simd calls become ill-formed and need to be removed. Thus, there's no difference anymore when compiling with DISABLE_SIMD and that extra benchmark executable can go. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
mattkretz
force-pushed
the
update-vir-simd-0.4
branch
from
a785060
to
f04a8b5
Compare
RalphSteinhagen
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
I can move the cmake changes into their own PR(s) if they are controversial.