Partial support of MacOs #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drslebedev <dr.s.lebedev@gmail.com>
| @@ -115,7 +115,9 @@ const boost::ut::suite SequenceTests = [] { | |||
| "Sequence"_test = [] { | |||
| using namespace gr; | |||
| using signed_index_type = std::make_signed_t<std::size_t>; | |||
| #if not defined(__APPLE__) | |||
| expect(eq(alignof(Sequence), 64UZ)); | |||
There was a problem hiding this comment.
Why does this not hold for iOS?
RalphSteinhagen
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
LGTM!
We need to ensure that the missing implementation for the thread handing on iOS (and eventually Windows) isn't missed. Users may have an expectation that when the respective functions are used that these either succeed or transparently fail. Presently these are silent functional failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on compiling and running GNU Radio 4 on macOS.
Changes
gcc-13andgcc-14installed via Homebrew.libc++library when usingclang-18; the default Apple compiler isclang-15.Known Issues