Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage: configure Sonarcube exclusions #413

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Coverage: configure Sonarcube exclusions #413

merged 3 commits into from
Nov 1, 2024

Conversation

wirew0rm
Copy link
Member

Fix sonarcube configuration to correctly exclude everything that is not run by the CI and therefore cannot have any coverage data. Also exclude a bunch of auxiliary files that are part of the build system or generic helper tools.

@wirew0rm wirew0rm marked this pull request as draft September 19, 2024 14:15
@wirew0rm wirew0rm marked this pull request as draft September 19, 2024 14:15
@wirew0rm
Copy link
Member Author

Fixing the CI related coverage issues is a prerequisite to #409 but due to the qa_Messages test not passing on the CI, no coverage/sonarcube reports are published and this cannot be tested properly...

Adds the restyled github action to check PRs for compliance with the
defined formatting rules and to suggest the correct restyling.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Applies the current formatter to the whole source to have smaller diffs
for feature PRs.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged once CI passes.

@wirew0rm wirew0rm marked this pull request as ready for review October 31, 2024 14:17
Fix sonarcube configuration to correctly exclude everything that is not
run by the CI and therefore cannot have any coverage data.
Also exclude a bunch of auxiliary files that are part of the build
system or generic helper tools.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Copy link

sonarcloud bot commented Nov 1, 2024

@wirew0rm wirew0rm merged commit 6dc7fd5 into main Nov 1, 2024
12 of 13 checks passed
@wirew0rm wirew0rm deleted the coverage branch November 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants